Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create middlware to add the client ip address to datadog tracing #1218

Merged
merged 6 commits into from
Jul 31, 2024

Conversation

wendelfabianchinsamy
Copy link
Contributor

@wendelfabianchinsamy wendelfabianchinsamy commented Jul 18, 2024

Purpose

closes: #1217

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@wendelfabianchinsamy wendelfabianchinsamy merged commit f3abb84 into master Jul 31, 2024
13 checks passed
@wendelfabianchinsamy wendelfabianchinsamy deleted the add-client-ip-address-to-datadog-tracing branch July 31, 2024 07:08
Copy link

sentry-io bot commented Jul 31, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Elasticsearch::Transport::Transport::Errors::BadRequest: [400] {"error":{"root_cause":[{"type":"token_mgr_error","reason":"token_mgr_error: Lexical error ... GraphqlController#execute View Issue
  • ‼️ Elasticsearch::Transport::Transport::Errors::BadRequest: [400] {"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"Result window is too... GraphqlController#execute View Issue
  • ‼️ Elasticsearch::Transport::Transport::Errors::BadRequest: [400] {"error":{"root_cause":[{"type":"token_mgr_error","reason":"token_mgr_error: Lexical error ... GraphqlController#execute View Issue
  • ‼️ TypeError: no implicit conversion of Integer into String GraphqlController#execute View Issue
  • ‼️ **NoMethodError: undefined method buckets' for nil:NilClass** DataciteDoisController#index` View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add client ip address to datadog tracing
2 participants