Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor specs for DOI relations through event data into separate file #1021

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

jrhoads
Copy link
Contributor

@jrhoads jrhoads commented Oct 16, 2023

Purpose

Refactors the specs for DOIs by separating out the tests for related dois through
events.

Renables the tests for related dois

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@jrhoads
Copy link
Contributor Author

jrhoads commented Oct 16, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@jrhoads jrhoads requested a review from a team October 16, 2023 13:29
Copy link
Member

@digitaldogsbody digitaldogsbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 more tests are never a bad thing!

@jrhoads jrhoads merged commit 3622661 into master Oct 16, 2023
11 of 20 checks passed
@jrhoads jrhoads deleted the 10-16-Refactor_DOI_relation_specs branch October 16, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants