Merge pull request #1014 from datacite/strip-orcid-url-scheme-out-on-…

…person-search strip out orcid url scheme for people search
datacite · Oct 3, 2023 · ee4b505 · ee4b505
2 parents 1e1c746 + 4c061ec
commit ee4b505
Show file tree

Hide file tree

Showing 3 changed files with 93 additions and 1 deletion.
diff --git a/app/graphql/types/query_type.rb b/app/graphql/types/query_type.rb
@@ -208,7 +208,8 @@ def person(id:)
   end
 
   def people(**args)
-    response = Person.query(args[:query], limit: args[:first], offset: args[:after].present? ? Base64.urlsafe_decode64(args[:after]) : nil)
+    query = args[:query].gsub(/^https?:\/\//, "")
+    response = Person.query(query, limit: args[:first], offset: args[:after].present? ? Base64.urlsafe_decode64(args[:after]) : nil)
     HashConnection.new(response, context: context, first: args[:first], after: args[:after])
   end
 

diff --git a/...cr_cassettes/PersonType/query_people_with_absolute_orcid_uri/returns_success_response.yml b/...cr_cassettes/PersonType/query_people_with_absolute_orcid_uri/returns_success_response.yml
diff --git a/spec/graphql/types/person_type_spec.rb b/spec/graphql/types/person_type_spec.rb
@@ -599,4 +599,34 @@
   #     )
   #   end
   # end
+
+  describe "query people with absolute orcid uri", elasticsearch: true, vcr: true do
+    let(:query) do
+      "query asdfsadfa {
+        people(first: 25, query: \"https://orcid.org/0000-0001-5727-2427\", after: null) {
+          totalCount
+          pageInfo {
+            endCursor
+            hasNextPage
+            __typename
+          }
+          nodes {
+            id
+            name
+            givenName
+            familyName
+            alternateName
+            __typename
+          }
+          __typename
+        }
+      }"
+    end
+
+    it "returns success response" do
+      response = LupoSchema.execute(query).as_json
+
+      expect(response.dig("data", "errors")).to(eq(nil))
+    end
+  end
 end