Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabrica Schema 3 Deprecation Tasks #892

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fabrica Schema 3 Deprecation Tasks #892

wants to merge 1 commit into from

Conversation

svogt0511
Copy link
Contributor

@svogt0511 svogt0511 commented Oct 25, 2024

Purpose

In Fabrica, creating/updating a DOI via form or file upload allows only the latest schema version to be used in both those operations. That mechanism is already in place using form validation and Lupo error checking.

The only task that needs to be done is to add appropriate tests to ensure that existing schema 3 DOIs can be updated to the latest schema version. Some data-test attributes were added to a few page elements to make testing easier.

Spec Documents

closes: #891

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

…ognized and can be updated to schema 4 via json or xml.
@svogt0511 svogt0511 self-assigned this Oct 25, 2024
@svogt0511 svogt0511 changed the title Schema 3 Deprecation Schema 3 Deprecation Tasks Oct 25, 2024
@svogt0511 svogt0511 changed the title Schema 3 Deprecation Tasks Fabrica Schema 3 Deprecation Tasks Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fabrica Schema 3 Deprecation Tasks
1 participant