Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds uniform horizontal spacing to facets list based on the container #451

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

codycooperross
Copy link
Contributor

Purpose

closes: Add github issue that originated this PR

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

Copy link

cypress bot commented Feb 4, 2025

akita    Run #1533

Run Properties:  status check passed Passed #1533  •  git commit 3f91f7fe3e: Adds uniform horizontal spacing to facets list based on the container
Project akita
Branch Review accordion-facets-spacing
Run status status check passed Passed #1533
Run duration 01m 33s
Commit git commit 3f91f7fe3e: Adds uniform horizontal spacing to facets list based on the container
Committer codycooperross
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 3
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 51
View all changes introduced in this branch ↗︎

@jrhoads jrhoads merged commit a350731 into accordion-facets Feb 4, 2025
11 checks passed
@jrhoads jrhoads deleted the accordion-facets-spacing branch February 4, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants