Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fair Workflows Release 1 #296

Merged
merged 7 commits into from
Dec 13, 2023
Merged

Fair Workflows Release 1 #296

merged 7 commits into from
Dec 13, 2023

Conversation

bklaing2
Copy link
Member

@bklaing2 bklaing2 commented Sep 26, 2023

Purpose

Implements features 1 and 4 of FAIR Workflows

Approach

Open Questions and Pre-Merge TODOs

  • Feature 1
  • Feature 2
  • Feature 4
  • Feature 5

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@bklaing2 bklaing2 requested a review from jrhoads September 26, 2023 13:20
@bklaing2 bklaing2 self-assigned this Sep 26, 2023
@cypress
Copy link

cypress bot commented Sep 26, 2023

Passing run #985 ↗︎

0 64 0 0 Flakiness 0

Details:

Merge 91255fc into b9a6eab...
Project: akita Commit: f25deff2c1 ℹ️
Status: Passed Duration: 02:20 💡
Started: Nov 14, 2023 10:45 AM Ended: Nov 14, 2023 10:47 AM

Review all test suite changes for PR #296 ↗︎

@bklaing2 bklaing2 force-pushed the fair-workflows-release-1 branch from a6d1689 to 6f84442 Compare October 19, 2023 14:47
bklaing2 and others added 6 commits November 7, 2023 16:12
* Added tabs for new relation types

* Added prototype connection type facet

* Replaced tabs with left-side facet

* Removed unnecessary Tab code

* Fixed bug where connection type wasn't selected by default

* Removed testing code

* Fixed undefined bug

* Reorder Conneciton types facets and allow Radio icons

* Added OtherRelated query

---------

Co-authored-by: jrhoads <[email protected]>
* Refactored DownloadReports to be more flexible

* Restructured API routes

* Added download related works for DOI

* Added connectionType column

---------

Co-authored-by: jrhoads <[email protected]>
Copy link

cypress bot commented Nov 14, 2023

Passing run #986 ↗︎

0 64 0 0 Flakiness 0

Details:

Fixed small related works header rendering issue
Project: akita Commit: 91255fc470
Status: Passed Duration: 02:08 💡
Started: Nov 14, 2023 10:47 AM Ended: Nov 14, 2023 10:49 AM

Review all test suite changes for PR #296 ↗︎

@bklaing2 bklaing2 marked this pull request as ready for review December 13, 2023 13:34
@bklaing2 bklaing2 merged commit 63cf389 into master Dec 13, 2023
@bklaing2 bklaing2 deleted the fair-workflows-release-1 branch December 13, 2023 13:34
@bklaing2 bklaing2 restored the fair-workflows-release-1 branch December 13, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants