Improve error handling in searchDoi queries with more robust error me…

…ssage generation
datacite · Feb 4, 2025 · 96e019b · 96e019b
1 parent f485ff9
commit 96e019b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/src/data/queries/searchDoiFacetsQuery.ts b/src/data/queries/searchDoiFacetsQuery.ts
@@ -71,10 +71,13 @@ export async function fetchDoisFacets(variables: QueryVar) {
     options
   )
   const json = await res.json()
-  if(!res.ok) throw new Error(json.errors.title)
+  if(!res.ok) {
+    const errorMessage = json?.errors?.title || `Request for facets failed with status: ${res.status}`;
+    throw new Error(errorMessage);
+  }
 
-    const data = convertToQueryData(json)
-    return { data }
+  const data = convertToQueryData(json)
+  return { data }
 }
 
 export function useSearchDoiFacetsQuery(variables: QueryVar) {

diff --git a/src/data/queries/searchDoiQuery.ts b/src/data/queries/searchDoiQuery.ts
@@ -80,10 +80,13 @@ export async function fetchDois(variables: QueryVar) {
   )
   const json = await res.json()
 
-  if(!res.ok) throw new Error(json.errors.title)
+  if(!res.ok) {
+    const errorMessage = json?.errors?.title || `Request for dois failed with status: ${res.status}`;
+    throw new Error(errorMessage);
+  }
 
-    const data = convertToQueryData(json)
-    return { data }
+  const data = convertToQueryData(json)
+  return { data }
 }