Skip to content

Commit

Permalink
Merge pull request #443 from datacite/no-prefetch
Browse files Browse the repository at this point in the history
Disable Link prefetching across components
  • Loading branch information
jrhoads authored Jan 21, 2025
2 parents 3154898 + 057ad73 commit 19ddc26
Show file tree
Hide file tree
Showing 8 changed files with 18 additions and 18 deletions.
2 changes: 1 addition & 1 deletion src/components/FacetList/FacetListItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export default function FacetListItem(props: Props) {
return (
<Row as="li" key={facet.id}>
<Col xs={1} className={styles.checkbox}>
<Link href={url + params.toString()} className={"facet-" + param}>
<Link prefetch={false} href={url + params.toString()} className={"facet-" + param}>
<FontAwesomeIcon icon={icon} />{' '}
</Link>
</Col>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ function TitleLink({ linkToExternal, id, name, alternateName, show }: TitleProps

function LinkWrapper({ children }: PropsWithChildren) {
if (!linkToExternal)
return <Link href={'/ror.org' + rorFromUrl(id)} className="fw-bold">{children}</Link>
return <Link prefetch={false} href={'/ror.org' + rorFromUrl(id)} className="fw-bold">{children}</Link>

return <a target="_blank" rel="noreferrer" href={id}>{children}</a>
}
Expand Down
2 changes: 1 addition & 1 deletion src/components/PersonEmployment/PersonEmployment.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const PersonEmployment: React.FunctionComponent<Props> = ({ employment }) => {

return (
<h4 className="work">
<Link href={'/grid.ac' + gridFromUrl(employment.organizationId)}>
<Link prefetch={false} href={'/grid.ac' + gridFromUrl(employment.organizationId)}>
{employment.organizationName}
</Link>
</h4>
Expand Down
4 changes: 1 addition & 3 deletions src/components/RepositoryDetail/RepositoryDetail.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export function RepositorySidebar({ repo }: Props) {
</Button>
)}
{repo.works && (repo.works.totalCount > 0) && (
<Link href={"/doi.org?query=client.uid:" + repo.clientId}>
<Link prefetch={false} href={"/doi.org?query=client.uid:" + repo.clientId}>
<Button variant="primary" id="find-related">
<FontAwesomeIcon icon={faNewspaper} />
&nbsp;
Expand Down Expand Up @@ -208,5 +208,3 @@ export function RepositoryDetail({ repo }: Props) {
</>
)
}


8 changes: 5 additions & 3 deletions src/components/RepositoryMetadata/RepositoryMetadata.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,11 @@ function RepositoryMetadata({ repo }: Props) {
return (
<Row key={repo.id} className="panel panel-transparent">
<Col className="panel-body">
<h3 className="fw-bold"><Link href={detailUrl()}>
{repo.name}
</Link></h3>
<h3 className="fw-bold">
<Link prefetch={false} href={detailUrl()}>
{repo.name}
</Link>
</h3>
{description()}
{tags()}
{links()}
Expand Down
4 changes: 2 additions & 2 deletions src/components/WorkFunding/WorkFunding.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const WorkFunding: React.FunctionComponent<Props> = ({ funding }) => {
)
return (
<h4 className="work">
<Link href={'/doi.org' + doiFromUrl(funding.funderIdentifier)}>
<Link prefetch={false} href={'/doi.org' + doiFromUrl(funding.funderIdentifier)}>
{funding.funderName}
</Link>
</h4>
Expand All @@ -37,7 +37,7 @@ const WorkFunding: React.FunctionComponent<Props> = ({ funding }) => {
)}
{showAwardLink && (
<div className="award">
<Link href={'/doi.org' + doiFromUrl(funding.funderIdentifier || '') + '?query=fundingReferences.awardNumber:(' + funding.awardNumber + ')'}>
<Link prefetch={false} href={'/doi.org' + doiFromUrl(funding.funderIdentifier || '') + '?query=fundingReferences.awardNumber:(' + funding.awardNumber + ')'}>
{funding.awardNumber}
</Link>
</div>
Expand Down
6 changes: 3 additions & 3 deletions src/components/WorkMetadata/WorkMetadata.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export default function WorkMetadata({
if (!metadata.titles[0])
return (
<h3 className="work">
<Link href={'/doi.org/' + metadata.doi}>
<Link prefetch={false} href={'/doi.org/' + metadata.doi}>
No Title
</Link>
</h3>
Expand All @@ -61,7 +61,7 @@ export default function WorkMetadata({

return (
<h3 className="work">
<Link href={'/doi.org/' + metadata.doi}>
<Link prefetch={false} href={'/doi.org/' + metadata.doi}>
{ReactHtmlParser(sanitizedTitle)}
</Link>
</h3>
Expand Down Expand Up @@ -123,7 +123,7 @@ export default function WorkMetadata({
<div className="creators">
{creatorList.map((c, index) =>
c.id !== null ? (
<Link href={'/orcid.org' + c.id} key={index}>
<Link prefetch={false} href={'/orcid.org' + c.id} key={index}>
{c.displayName}
</Link>
) : (
Expand Down
8 changes: 4 additions & 4 deletions src/components/WorkPerson/WorkPerson.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const WorkPerson: React.FunctionComponent<Props> = ({ person }) => {
return (
<>
<h4 className="work">
<Link href={'/orcid.org' + orcidFromUrl(person.id)}>
<Link prefetch={false} href={'/orcid.org' + orcidFromUrl(person.id)}>
{name}
</Link>
</h4>
Expand All @@ -42,7 +42,7 @@ const WorkPerson: React.FunctionComponent<Props> = ({ person }) => {
{person.affiliation?.map((item) =>
item.id ? (
<div className="affiliation" key={item.id}>
<Link href={'/ror.org' + rorFromUrl(item.id)}>
<Link prefetch={false} href={'/ror.org' + rorFromUrl(item.id)}>
{item.name}
</Link>
</div>
Expand All @@ -65,7 +65,7 @@ const WorkPerson: React.FunctionComponent<Props> = ({ person }) => {
return (
<>
<h4 className="work">
<Link href={'/ror.org' + rorFromUrl(person.id)}>
<Link prefetch={false} href={'/ror.org' + rorFromUrl(person.id)}>
{name}
</Link>
</h4>
Expand All @@ -75,7 +75,7 @@ const WorkPerson: React.FunctionComponent<Props> = ({ person }) => {
{person.affiliation?.map((item) =>
item.id ? (
<div className="affiliation" key={item.id}>
<Link href={'/ror.org' + rorFromUrl(item.id)}>
<Link prefetch={false} href={'/ror.org' + rorFromUrl(item.id)}>
{item.name}
</Link>
</div>
Expand Down

0 comments on commit 19ddc26

Please sign in to comment.