Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved working on swd exercise #474

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Conversation

pow123
Copy link
Contributor

@pow123 pow123 commented Jul 25, 2023

Learners were confused by the exercise as they thought activities 2, 3, and 4 were using interviews_100. So, I recommend adding clarifying language.

@github-actions
Copy link

github-actions bot commented Jul 25, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/r-socialsci/compare/md-outputs..md-outputs-PR-474

The following changes were observed in the rendered markdown documents:

 02-starting-with-data.md            |   2 +
 data-visualisation-handout.md (new) | 293 ++++++++++++++++++++++++++++++++++++
 data-wrangling-handout.md (new)     | 284 ++++++++++++++++++++++++++++++++++
 intro-R-handout.md (new)            | 212 ++++++++++++++++++++++++++
 md5sum.txt                          |   6 +-
 starting-with-data-handout.md (new) | 240 +++++++++++++++++++++++++++++
 6 files changed, 1036 insertions(+), 1 deletion(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-07-25 18:42:12 +0000

github-actions bot pushed a commit that referenced this pull request Jul 25, 2023
@juanfung
Copy link
Contributor

@pow123 great catch thank you!

@juanfung juanfung merged commit b20861c into datacarpentry:main Jul 25, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 25, 2023
Auto-generated via {sandpaper}
Source  : b20861c
Branch  : main
Author  : Juan Fung <[email protected]>
Time    : 2023-07-25 18:54:00 +0000
Message : Merge pull request #474 from pow123/patch-2

improved working on swd exercise
github-actions bot pushed a commit that referenced this pull request Jul 25, 2023
Auto-generated via {sandpaper}
Source  : 2ace5ec
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2023-07-25 18:55:54 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : b20861c
Branch  : main
Author  : Juan Fung <[email protected]>
Time    : 2023-07-25 18:54:00 +0000
Message : Merge pull request #474 from pow123/patch-2

improved working on swd exercise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants