Fix explanation of NA result from separate_rows() function
#473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits. It should be safe to Approve and Run the workflows that need maintainer approval. |
|
@maltelueken great catch thank you! |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
Auto-generated via {sandpaper}
Source : e0f54e6
Branch : main
Author : Juan Fung <[email protected]>
Time : 2023-07-25 18:53:23 +0000
Message : Merge pull request #473 from maltelueken/fix-sep-rows-explanation
Fix explanation of `NA` result from `separate_rows()` function
github-actions bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
Auto-generated via {sandpaper}
Source : 08a8030
Branch : md-outputs
Author : GitHub Actions <[email protected]>
Time : 2023-07-25 18:55:41 +0000
Message : markdown source builds
Auto-generated via {sandpaper}
Source : e0f54e6
Branch : main
Author : Juan Fung <[email protected]>
Time : 2023-07-25 18:53:23 +0000
Message : Merge pull request #473 from maltelueken/fix-sep-rows-explanation
Fix explanation of `NA` result from `separate_rows()` function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the explanation of what the
separate_rows()function does in the "Applyingpivot_wider()to clean our data" section of the episode "Data Wrangling with tidyr" is not correct. It originally says that there is a column with the nameNAafter applyingseparate_rows(). However, what actually happens is that the columnitems_ownedcontainsNAvalues. These are replaced with the following commandreplace_na().I fixed the explanation of what happens after
separate_rows(). Please feel free to comment on/suggest an alternative phrasing.#462 discusses to replace
separate_rows()byseparate_longer_delim(). The corrected explanation in this PR still hold for the preferredseparate_longer_delim()function.