Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistake in challenge in Lesson 7 #462

Closed
S-D-Miller opened this issue Jan 19, 2025 · 1 comment · Fixed by #463
Closed

Mistake in challenge in Lesson 7 #462

S-D-Miller opened this issue Jan 19, 2025 · 1 comment · Fixed by #463
Assignees

Comments

@S-D-Miller
Copy link

What is the problem?

In Lesson 7 - Vector Shapefile Attributes in R, there is an error in the Challenge "Plot Line Width by Attribute". In the second line of the plotting code in the solution:

geom_sf(data = lines_HARV, aes(size = TYPE)) +

should be:

geom_sf(data = lines_HARV, aes(linewidth = TYPE)) +

Using size in aes() doesn't change the linewidth properly in the figure. The figure in the solution should also be updated to show the true solution.

Location of problem (optional)

https://datacarpentry.github.io/r-raster-vector-geospatial/07-vector-shapefile-attributes-in-r.html

@jonjab
Copy link
Contributor

jonjab commented Jan 21, 2025

yes definitely. this has been there a while. I have eliminated size= completely from episode 7, along with the following changes from other issues:

#256 -- cutting the formatting that never gets demonstrated
#341 -- softened the transition from points to lines
#262
#357
#356 -- dplyr is needed, and I added the other necessary libraries
#436 -- removing hard-coded maintainers list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants