-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove markdown linting warnings - see #117 #123
Conversation
Thanks for your contribution, @jcohen02! This looks good so far. As you mention you intend to add more commits to fix the other files, I'll keep this open for now and approve when the other files are ready. (If you don't have time for more, no worries! I could just remove the "closes issue" link and merge.) |
No problem @bencomp, happy to help. I think this should now be done, if you could approve the running of the GHA workflow, the previous line length errors are now hopefully resolved.
Yes, indeed, I've tried to check the rendered site locally as I've been going along with the changes to see that nothing has broken the formatting in the lesson content. I think this all looks OK but would welcome someone more familiar with the lesson content giving this a quick check through when reviewing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work! It renders correctly, even with the whitespace inside the Markdown links.
|
||
![History](../fig/history.png) | ||
![History](../fig/history.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, this seems to fix an issue mentioned in #95 (which was closed already, without providing a fix...)
Remove markdown linting warnings - see #117
This PR removes a number of linter warnings relating to line length on markdown files, as detailed in #117.
In addition to the line length issues, a few other Markdown formatting changes have been made to address warnings raised when running
markdownlint
on files locally (e.g. trailing spaces, multiple blank lines, ...).Opening the PR to check that the changes are indeed resolving the warnings - currently a small group of files have been updated, the remainder will be updated in the coming days and additional commits with further changes pushed to this PR.
Closes #117
(Contributing to Hacktoberfest! - please add hacktoberfest-accepted tag as and when PR is accepted and merged 🎉 )