Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script episode indicates time for exercise, but there is no exercise #121

Closed
bencomp opened this issue Oct 4, 2022 · 0 comments · Fixed by #159
Closed

Script episode indicates time for exercise, but there is no exercise #121

bencomp opened this issue Oct 4, 2022 · 0 comments · Fixed by #159
Labels
status:in progress Contributor working on issue

Comments

@bencomp
Copy link
Contributor

bencomp commented Oct 4, 2022

Originally posted by @leannethelibrarian in #95 (comment)

Scripts episode:

  • Overview - it says "exercises 10 min" but there are no exercises indicated for this lesson.
  • Saving you work as a script section - bullet "1" appears twice (before and after the screenshot)

I think the intent was that there is no real distinction between teaching and exercise. In other words, the steps could be presented as a walk-through that instructor and learners do together, or be presented as the exercise.

Let me suggest that there be two exercise blocks:

  1. Saving actions to a script
  2. Applying the actions and checking that the results are the same

I'll happily accept a pull request to make these changes.

Checking that the results are the same can be important. I have noticed that changing the value of a single cell in the 'table' may not be recorded as an exportable action. That may vary with OpenRefine versions, but we probably should warn about this. (I can open a new issue for this.)

@bencomp bencomp added help wanted Looking for Contributors good first issue Good issue for first-time contributors labels Oct 4, 2022
@bencomp bencomp added status:in progress Contributor working on issue and removed help wanted Looking for Contributors good first issue Good issue for first-time contributors labels May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:in progress Contributor working on issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant