-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
datacarpentry/openrefine-socialsci #49
Comments
First: thanks for your efforts! Callouts are not (always?) translated into new style callouts. First section title appears above objectives. A link text and the link itself are mangled: "Show me the solution" partially obscures body text. I noticed that the last episode links to the start with another "next" link. Is that intentional? |
Hi @bencomp, thank you for your patience. I have gone through the issues you have pointed out and most of them have been fixed! The only two that remain are the untranslated callout block (this I will fix) and the encroaching solution block. I apologise for the solution block kerfuffle, but unfortunatley, they are a bit more buoyant in the workbench. The solution is to give them another callout block or div to glom onto. My suggestion would be, after the transition, combine the 5th and 6th points into a discussion/solution block, which will end up like this: This is how you would code it (note the indent of 3 spaces to maintain the list item block): 5. Hover the mouse over one of the names in the `Facet` list. You should see
that you have an `edit` function available.
::::::::::::::: discussion
### Better ways to fix errors
You could use this to fix an error immediately, and OpenRefine will ask
whether you want to make the same correction to every value it finds like
that one. But OpenRefine offers even better ways to find and fix these
errors, which we'll use instead. We'll learn about these when we talk about
clustering.
::::::::::::::::::::::::::
::::::::::::::: solution
### Available alternatives
- `Chirdozo` is likely a mis-entry of `Chirodzo`.
- `Ruca` is likely a mis-entry of `Ruaca`.
- `Ruaca - Nhamuenda` and `Ruaca-Nhamuenda` refer to the same place (differ
only by spaces around the hyphen). You might also wonder if both of these
are the same as `Ruaca`. We will see how to correct these misspelled and
mistyped entries in a later exercise.
- The entry `49` is almost certainly an error but you will not be able to fix
it by reference to other data.
:::::::::::::::::::::::::
|
This addresses datacarpentry/openrefine-socialsci (#49)
Hi @zkamvar, thanks for fixing the issues and commenting. I did indeed notice that some things looked better already :) I think the encroaching block is also related to #datacarpentry/openrefine-socialsci#121 – as we have a solution without corresponding exercise. I will have a look at transforming the whole thing into exercise+solution, or following your solution. |
That's great! I will comment within the next hour about the transition once I run my tests. |
fixed in a36c90e |
tracking issues for https://github.com/datacarpentry/openrefine-socialsci/
The text was updated successfully, but these errors were encountered: