Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Work in progress!] Docker configuration for genomics workshop #44

Closed
wants to merge 1 commit into from

Conversation

standage
Copy link

During last week's bug BBQ, several related threads all ran together for me.

On Friday (and a bit on Saturday) I prototyped a Docker image with the software required to run most of the genomics modules. Note: I haven't installed R or Rstudio yet since I'm not familiar with those materials, but this shouldn't be too difficult to add.
This is a work in progress that ties all of these related issues together.

Before I got much further, I wanted to open this up for discussion and feedback.

  • Any thoughts on the data set?
  • Should we try to handle these issues piece by piece, or does it make sense to address them all at once?

@standage
Copy link
Author

cc @tracykteal @ErinBecker

@standage
Copy link
Author

Note: the bcftools flags used in the existing materials are outdated. I used this page to inform my updates to the variant calling workflow.

@raynamharris
Copy link

Thanks, @standage for the details. I like that you have chosen a new dataset is still from the Lenski experiments. I think this will minimize the number of changes that need to be made to update the story about the data.

As for updating piece by piece or all at once, how interdependent or overlapping are the suggested changes? Like, how many changes have downstream effects that you may as well address all at once?

@standage
Copy link
Author

The bwa mem issue and the new data set are tightly coupled. The others could potentially be handled in a more granular fashion if there was good reason to. But they're related enough that I could handle them all together in a single sweeping change. There would need to be a lot of coordination and communication though, as this will affect a lot of different pieces.

@sk-sahu sk-sahu marked this pull request as draft March 25, 2021 14:04
@twrightsman twrightsman added the type:enhancement Propose enhancement to the lesson label May 2, 2023
@twrightsman twrightsman added this to the Workbench Transition milestone May 20, 2023
@twrightsman
Copy link
Member

Given that we now have two methods (AMI or Conda) to set up the software environment (see #28) and because we need to close all PRs before the workbench transition, I will close this; feel free to re-open after the transition if someone feels strongly that Docker should also be an option!

@twrightsman twrightsman closed this Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Propose enhancement to the lesson
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants