Remove redundant if-condition in the GraphWalker._iter_one
#3654
+9
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCZuurmond
added
migrate/code
JCZuurmond
temporarily deployed
to
account-admin
GitHub Actions
Inactive
JCZuurmond
commented
Feb 6, 2025
| @@ -56,16 +56,15 @@ def _iter_one(self, dependency: Dependency, graph: DependencyGraph, root_path: P | |||
| self._lineage.append(dependency) | |||
| self._walked_paths.add(dependency.path) | |||
| self._log_walk_one(dependency) | |||
| if dependency.path.is_file() or is_a_notebook(dependency.path): | |||
There was a problem hiding this comment.
@pritishpai and @asnare : This is another if-condition in this method about which I am unsure. However, I want to remove it as it is interfering with surfacing known problems during linting.
Notes:
- Removing the
if-condition does not let any unit test fail - The condition was introduced without notes, explanation or questions
- IMO the base graph walker class should not decide to skip a dependency. Classes that inherit form this class can decide to skip specific dependencies
- I introduced a new dependency to surface known problems,
KnownDependency, which is not processed as the condition is not true for that dependency. Instead of extending the condition, I think it should be removed all together
|
✅ 57/57 passed, 2 skipped, 1h14m58s total Running from acceptance #8219 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove redundant
if-condition in theGraphWalker._iter_oneLinked issues
Progresses #3626
Functionality