Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ignoring files and notebooks #3653

Merged
merged 8 commits into from
Feb 11, 2025
Merged

Support ignoring files and notebooks #3653

merged 8 commits into from
Feb 11, 2025
+163 −54

Conversation

JCZuurmond
Copy link
Member

@JCZuurmond JCZuurmond commented Feb 6, 2025 •
edited
Loading

Changes

Support ignoring files and notebooks

Linked issues

Progresses #3645

Functionality

  • modified file and notebook loading in the source code related modules

Tests

  • added unit tests

@JCZuurmond JCZuurmond added migrate/code Abstract Syntax Trees and other dark magic migrate/python Pull requests that update Python code python Pull requests that update Python code internal this pull request won't appear in release notes labels Feb 6, 2025
@JCZuurmond JCZuurmond self-assigned this Feb 6, 2025
@JCZuurmond JCZuurmond requested a review from a team as a code owner February 6, 2025 12:50
@JCZuurmond JCZuurmond mentioned this pull request Feb 6, 2025
Open
2 tasks
JCZuurmond added a commit that referenced this pull request Feb 6, 2025
@JCZuurmond
Remove ignoring paths on Folder and FolderLoader
e7471ed 
Preference goes to #3653
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025 •
edited
Loading

✅ 57/57 passed, 2 skipped, 33m22s total

Running from acceptance #8215

@JCZuurmond JCZuurmond force-pushed the feat/ignore-path-on-file-and-notebook branch from 437ea82 to 0ef3a62 Compare February 6, 2025 13:15
@JCZuurmond JCZuurmond added this pull request to the merge queue Feb 11, 2025
Merged via the queue into main with commit 3583396 Feb 11, 2025
7 checks passed
@JCZuurmond JCZuurmond deleted the feat/ignore-path-on-file-and-notebook branch February 11, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pritishpai pritishpai pritishpai approved these changes

@FastLee FastLee Awaiting requested review from FastLee

Assignees

@JCZuurmond JCZuurmond

Labels
internal this pull request won't appear in release notes migrate/code Abstract Syntax Trees and other dark magic migrate/python Pull requests that update Python code python Pull requests that update Python code
Projects
UCX
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JCZuurmond @pritishpai