[TECH DEBT] Improve file handling by FileLoader
#3640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCZuurmond
added
migrate/code
JCZuurmond
temporarily deployed
to
account-admin
GitHub Actions
Inactive
|
✅ 57/57 passed, 2 skipped, 25m17s total Running from acceptance #8193 |
7 tasks
JCZuurmond
temporarily deployed
to
account-admin
GitHub Actions
Inactive
JCZuurmond
commented
Feb 5, 2025
| ): | ||
| super().__init__(cwd, sys_paths or []) | ||
|
|
||
| self.successfully_resolved_paths = set[Path]() # The paths that were successfully resolved |
There was a problem hiding this comment.
Note that this attribute should be used in tests instead of passing a set for the linted paths as this is correct and it actually was a bug that the paths were not resolved
pritishpai
approved these changes
Feb 5, 2025
JCZuurmond
temporarily deployed
to
account-admin
GitHub Actions
Inactive
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
…ing back on its path (#3641) ## Changes Let `LocalFileLinter` reuse the `Dependency` instead falling back on its path as this introduce duplicate ways of loading files. ### Linked issues Progresses #3514 Breaks up #3520 Stacked on: - [x] #3640 - [x] #3639 - [x] #3638 ### Functionality - [x] modified existing command: `databricks labs ucx migrate-local-code` ### Tests - [ ] manually tested - [x] modified and added unit tests - [x] modified and added integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Improve file handling by
FileLoader:FileLoaderresolves files using thePathLookupPermissionError,FileNotFoundErrorLinked issues
Breaks up #3586
Functionality
Tests
FileLoader