Align DependencyProblem with LocatedAdvice
#3583
Open
+97
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCZuurmond
added
migrate/code
JCZuurmond
temporarily deployed
to
account-admin
GitHub Actions
Inactive
JCZuurmond
commented
Jan 29, 2025
| @@ -58,10 +57,3 @@ def test_graph_imports_dynamic_import(): | |||
| container = maybe.dependency.load(path_lookup) | |||
| problems = container.build_dependency_graph(graph) | |||
| assert not problems | |||
|
|
|||
|
|
|||
| def test_is_path_missing(): | |||
There was a problem hiding this comment.
This was not an integration test
|
✅ 57/57 passed, 2 skipped, 25m51s total Running from acceptance #8117 |
JCZuurmond
temporarily deployed
to
account-admin
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
While graph building for linting, the
DependencyProblemare converted toLocatedAdvice. This PR aligns the two classesLinked issues
Progresses #3514
Breaks up #3520
Functionality
databricks labs ucx migrate-local-codeTests