Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move graph walkers to separate module #3581

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

JCZuurmond
Copy link
Member

Changes

Move all graph walkers into a separate module graph_walkers.py under the linters module to centralize them, because they are used for linting only and to reuse them instead of recreating them

Linked issues

Progresses #3514
Breaks up #3520

Functionality

  • modified existing command: databricks labs ucx migrate-local-code

Tests

  • manually tested
  • modified and added unit tests
  • modified and added integration tests

@JCZuurmond JCZuurmond added migrate/code Abstract Syntax Trees and other dark magic migrate/python Pull requests that update Python code python Pull requests that update Python code internal this pull request won't appear in release notes labels Jan 29, 2025
@JCZuurmond JCZuurmond self-assigned this Jan 29, 2025
@JCZuurmond JCZuurmond requested a review from a team as a code owner January 29, 2025 08:27
Copy link

github-actions bot commented Jan 29, 2025

✅ 57/57 passed, 2 skipped, 41m55s total

Running from acceptance #8152

@JCZuurmond JCZuurmond force-pushed the refactor/move-graph-walkers-to-separate-module branch from b480e50 to b3a015a Compare January 31, 2025 09:02
@JCZuurmond JCZuurmond added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 3ca395c Feb 4, 2025
7 checks passed
@JCZuurmond JCZuurmond deleted the refactor/move-graph-walkers-to-separate-module branch February 4, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal this pull request won't appear in release notes migrate/code Abstract Syntax Trees and other dark magic migrate/python Pull requests that update Python code python Pull requests that update Python code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants