Added checker for multiline list comprehensions ban #48
+61
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfx
added a commit
that referenced
this pull request
Oct 3, 2024
* Added checker for multiline list comprehensions ban ([#48](#48)). A new checker, `readability`, has been implemented in the PyLint plugin for Databricks, introducing a new code rule `R8923` that flags multiline list comprehensions. This change aims to improve code readability by suggesting a rewrite as a for loop when list comprehensions span multiple lines. The checker can be used by adding `databricks.labs.pylint.readability` to the `load-plugins` configuration in the `pylintrc` or `pyproject.toml` file. The commit also includes updates to the README file, documenting the new checker and the `R8923` check, along with examples and instructions for using and disabling it. Additionally, new test functions have been added to `test_readability.py` to demonstrate the ability to enforce a ban on multiline list comprehensions. * Bump sigstore/gh-action-sigstore-python from 2.1.1 to 3.0.0 ([#47](#47)). In version 3.0.0 of sigstore/gh-action-sigstore-python, several changes and bug fixes have been implemented. Notable updates include the addition of recursive globbing with **, and the removal of certain settings such as fulcio-url, rekor-url, ctfe, and rekor-root-pubkey. The output settings signature, certificate, and bundle have also been removed, and inputs are now parsed according to POSIX shell lexing rules. The release-signing-artifacts setting no longer causes a hard error when used under the incorrect event. Additionally, the default suffix has changed from .sigstore to .sigstore.json, and release-signing-artifacts now defaults to true. This version also supports CI runners that use PEP 668 to constrain global package prefixes. Dependency updates: * Bump sigstore/gh-action-sigstore-python from 2.1.1 to 3.0.0 ([#47](#47)).
Merged
nfx
added a commit
that referenced
this pull request
Oct 3, 2024
* Added checker for multiline list comprehensions ban ([#48](#48)). A new checker, `readability`, has been implemented in the PyLint plugin for Databricks, introducing a new code rule `R8923` that flags multiline list comprehensions. This change aims to improve code readability by suggesting a rewrite as a for loop when list comprehensions span multiple lines. The checker can be used by adding `databricks.labs.pylint.readability` to the `load-plugins` configuration in the `pylintrc` or `pyproject.toml` file. The commit also includes updates to the README file, documenting the new checker and the `R8923` check, along with examples and instructions for using and disabling it. Additionally, new test functions have been added to `test_readability.py` to demonstrate the ability to enforce a ban on multiline list comprehensions. * Bump sigstore/gh-action-sigstore-python from 2.1.1 to 3.0.0 ([#47](#47)). In version 3.0.0 of sigstore/gh-action-sigstore-python, several changes and bug fixes have been implemented. Notable updates include the addition of recursive globbing with **, and the removal of certain settings such as fulcio-url, rekor-url, ctfe, and rekor-root-pubkey. The output settings signature, certificate, and bundle have also been removed, and inputs are now parsed according to POSIX shell lexing rules. The release-signing-artifacts setting no longer causes a hard error when used under the incorrect event. Additionally, the default suffix has changed from .sigstore to .sigstore.json, and release-signing-artifacts now defaults to true. This version also supports CI runners that use PEP 668 to constrain global package prefixes. Dependency updates: * Bump sigstore/gh-action-sigstore-python from 2.1.1 to 3.0.0 ([#47](#47)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.