Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix raster docs based on Python docstrings #377

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mihaigurau-tomtom
Copy link

Just a few small edits of the docs for Raster Functions, particularly regarding descriptions of returns for rst_rastertogridcount and rst_rastertogridmin.

I think it'd be nice to update the images for the rst_rastertogrid* functions as well, as they seem to be inconsistent & now all link to the output of rst_rastertogridavg. However, I couldn't generate the images myself, hence that change may be part of a different PR.

Cheers! :)

@milos-colic
Copy link
Contributor

@mihaigurau-tomtom We have now opened up the process for merging the external PRs.
Can you please confirm with the: https://github.com/databrickslabs/mosaic/blob/main/CONTRIBUTING.md?
After your PR is compliant, I am happy to review it and merge it if the review is successful.

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #377 (1ef9e02) into main (bb49756) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #377   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files         198      198           
  Lines        5655     5655           
  Branches      181      181           
=======================================
  Hits         5372     5372           
  Misses        283      283           

@edurdevic
Copy link
Contributor

Hi @mihaigurau-tomtom , in order for us to proceed it is sufficient to add a comment to this PR with your sign-off (Eg. Signed-off-by: Joe Smith <[email protected]>).
We need this to make sure you are aware of the current license, and that you agree with open sourcing it. :)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants