Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing FileNotFoundError on onboarding file dir #57

Conversation

btello
Copy link

@btello btello commented Jun 26, 2024

When attempting to run the onboarding CLI if you accept the default or specify a relative path for the path to the onboarding files directory you'll get a FileNotFoundError. This seems to be because the file schema URI implementation in DBFS doesn't honor relative paths. This patch makes the onboarding files directory path absolute.

Copy link
Contributor

@ravi-databricks ravi-databricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ravi-databricks ravi-databricks merged commit 7f32462 into databrickslabs:feature/v0.0.8 Jul 2, 2024
1 check failed
@ravi-databricks
Copy link
Contributor

@btello can you take look at this : #59 before we release this to main branch

@ravi-databricks ravi-databricks added the bug Something isn't working label Jul 10, 2024
@ravi-databricks ravi-databricks added this to the v0.0.8 milestone Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants