Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 41 #45

Merged
merged 19 commits into from
Apr 15, 2024
Merged

Feature/issue 41 #45

merged 19 commits into from
Apr 15, 2024

Conversation

howardwu-db
Copy link
Contributor

merging issue 41 gifs into main

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.90%. Comparing base (077c71d) to head (51a98f4).

❗ Current head 51a98f4 differs from pull request most recent head 7b2d6b1. Consider uploading reports for the commit 7b2d6b1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   89.90%   89.90%           
=======================================
  Files           8        8           
  Lines         832      832           
  Branches      161      161           
=======================================
  Hits          748      748           
  Misses         33       33           
  Partials       51       51           
Flag Coverage Δ
unittests 89.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- code to open databricks workspace in CLI and Demo
- Corrected onboarding params in docs
1.min python version in labs.yam same as setup.py
2.increased version to 0.0.7
Copy link
Contributor Author

@howardwu-db howardwu-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@ganeshchand ganeshchand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ravi-databricks ravi-databricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ravi-databricks ravi-databricks merged commit 423a776 into main Apr 15, 2024
2 of 3 checks passed
@ravi-databricks ravi-databricks deleted the feature/issue_41 branch April 30, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants