Allow to specify source database instead of defaulting to bronze database in __get_silver_dataflow_spec_dataframe #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravi-databricks
requested changes
Jan 22, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
- Coverage 90.28% 89.95% -0.34%
==========================================
Files 8 8
Lines 803 806 +3
Branches 149 151 +2
==========================================
Hits 725 725
- Misses 31 32 +1
- Partials 47 49 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@rtdtwo, Needs to add unit tests for added new lines as per above code coverage report. |
| } | ||
| if f"bronze_database_{env}" in onboarding_row: | ||
| source_details = { | ||
| "database": onboarding_row["bronze_database_{}".format(env)], |
There was a problem hiding this comment.
Why not use f"bronze_database_{env}" as in if above (which IMHO is more pythonic)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The FAQs describes that any data source can be used for silver tables. However, the code always tries to find the bronze database from the onboarding rows, and there's no explicit mention of a source database other than a bronze database.
Fix
Change the code to accomplish the following:
bronze_database_{env}if the field is found in onboarding rows.source_details.