Support the FastAPI app being mounted. #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmilkov
approved these changes
Feb 13, 2024
derek-pyne
reviewed
Feb 14, 2024
|
|
||
| curl --fail --silent "http://localhost:$PORT/lilac_sub/api/v1/tasks/" | ||
|
|
||
| curl --fail --silent "http://localhost:$PORT/lilac_sub/" |
There was a problem hiding this comment.
The issue we're seeing with mounting lilac is the infinite redirects... and this test isn't quite catching it right now. Changing to this would show the failure:
curl --fail --silent "http://localhost:$PORT/lilac_sub/" -L --max-redirs 0
and if you remove --silent show something like this:
Interesting that the api and docs work totally fine :)
|
I haven't yet released this! Did you try checking out from head? I fixed the infinite redirect, but good point I will fix the unit test :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1170