Merge remote-tracking branch 'origin' into ds-fix-open-ds-concept

databricks · Jan 24, 2024 · 2db7aac · 2db7aac
2 parents f08119a + a979336
commit 2db7aac
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lilac/data/dataset_duckdb.py b/lilac/data/dataset_duckdb.py
@@ -3654,7 +3654,7 @@ def _replace_nan_with_none(df: pd.DataFrame) -> pd.DataFrame:
   # TODO(https://github.com/duckdb/duckdb/issues/4066): Remove this once duckdb fixes upstream.
   for col in df.columns:
     if is_object_dtype(df[col]):
-      df[col].replace(np.nan, None, inplace=True)
+      df[col] = df[col].replace(np.nan, None)
   return df