Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Open AI Client Mixin #779

Merged
merged 16 commits into from
Oct 10, 2024
Merged

[Feature] Open AI Client Mixin #779

merged 16 commits into from
Oct 10, 2024

Conversation

aravind-segu
Copy link
Contributor

Changes

Add Open AI Client Mixing with the Serving Endpoints API. Open AI Client requires a token to be authenticated. Therefore we are moving the creation of OpenAI client to the databricks sdk so that users can easily use it in both the notebook and model serving environments

Tests

Dogfood Test: https://e2-dogfood.staging.cloud.databricks.com/editor/notebooks/2337940012762945?o=6051921418418893

  • make test run locally
  • make fmt applied
  • relevant integration tests applied

@aravind-segu aravind-segu force-pushed the open_ai_client branch 3 times, most recently from 8b90ae8 to 79abd8f Compare October 4, 2024 00:57
@aravind-segu aravind-segu changed the title [ML-45784] Open AI Client Mixin Open AI Client Mixin Oct 4, 2024
@aravind-segu aravind-segu changed the title Open AI Client Mixin [Feature] Open AI Client Mixin Oct 4, 2024
mgyucht
mgyucht reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check with legal about if there are any concerns about adding these optional dependencies. I started a thread internally with the four of us to discuss.

@aravind-segu aravind-segu requested a review from mgyucht October 8, 2024 19:08
@mgyucht mgyucht enabled auto-merge October 9, 2024 07:36
@aravind-segu
Copy link
Contributor Author

jenkins merge

auto-merge was automatically disabled October 9, 2024 20:57

Head branch was pushed to by a user without write access

@mgyucht mgyucht added this pull request to the merge queue Oct 10, 2024
Merged via the queue into databricks:main with commit 1c75815 Oct 10, 2024
14 checks passed
rauchy added a commit that referenced this pull request Oct 17, 2024
@rauchy
[Release] Release v0.35.0
9c5d1ce 
### New Features and Improvements

 * Open AI Client Mixin ([#779](#779)).

### Bug Fixes

 * Update Serving Endpoint mixing template and docs generation logic ([#792](#792)).

### API Changes:

 * Added `databricks.sdk.service.pipelines.ReportSpec` dataclass.
 * Added `unity_catalog_provisioning_state` field for `databricks.sdk.service.catalog.OnlineTable`.
 * Added `is_truncated` field for `databricks.sdk.service.dashboards.Result`.
 * Added `effective_budget_policy_id` field for `databricks.sdk.service.jobs.BaseJob`.
 * Added `budget_policy_id` field for `databricks.sdk.service.jobs.CreateJob`.
 * Added `effective_budget_policy_id` field for `databricks.sdk.service.jobs.Job`.
 * Added `budget_policy_id` field for `databricks.sdk.service.jobs.JobSettings`.
 * Added `budget_policy_id` field for `databricks.sdk.service.jobs.SubmitRun`.
 * Added `report` field for `databricks.sdk.service.pipelines.IngestionConfig`.
 * Added `sequence_by` field for `databricks.sdk.service.pipelines.TableSpecificConfig`.
 * Added `notify_on_ok` field for `databricks.sdk.service.sql.Alert`.
 * Added `notify_on_ok` field for `databricks.sdk.service.sql.CreateAlertRequestAlert`.
 * Added `notify_on_ok` field for `databricks.sdk.service.sql.ListAlertsResponseAlert`.
 * Added `notify_on_ok` field for `databricks.sdk.service.sql.UpdateAlertRequestAlert`.

OpenAPI SHA: cf9c61453990df0f9453670f2fe68e1b128647a2, Date: 2024-10-14
@rauchy rauchy mentioned this pull request Oct 17, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 17, 2024
@rauchy
[Release] Release v0.35.0 (#793)
15257eb 
### New Features and Improvements

* Open AI Client Mixin
([#779](#779)).


### Bug Fixes

* Update Serving Endpoint mixing template and docs generation logic
([#792](#792)).


### API Changes:

 * Added `databricks.sdk.service.pipelines.ReportSpec` dataclass.
* Added `unity_catalog_provisioning_state` field for
`databricks.sdk.service.catalog.OnlineTable`.
* Added `is_truncated` field for
`databricks.sdk.service.dashboards.Result`.
* Added `effective_budget_policy_id` field for
`databricks.sdk.service.jobs.BaseJob`.
* Added `budget_policy_id` field for
`databricks.sdk.service.jobs.CreateJob`.
* Added `effective_budget_policy_id` field for
`databricks.sdk.service.jobs.Job`.
* Added `budget_policy_id` field for
`databricks.sdk.service.jobs.JobSettings`.
* Added `budget_policy_id` field for
`databricks.sdk.service.jobs.SubmitRun`.
* Added `report` field for
`databricks.sdk.service.pipelines.IngestionConfig`.
* Added `sequence_by` field for
`databricks.sdk.service.pipelines.TableSpecificConfig`.
 * Added `notify_on_ok` field for `databricks.sdk.service.sql.Alert`.
* Added `notify_on_ok` field for
`databricks.sdk.service.sql.CreateAlertRequestAlert`.
* Added `notify_on_ok` field for
`databricks.sdk.service.sql.ListAlertsResponseAlert`.
* Added `notify_on_ok` field for
`databricks.sdk.service.sql.UpdateAlertRequestAlert`.

OpenAPI SHA: cf9c61453990df0f9453670f2fe68e1b128647a2, Date: 2024-10-14

Co-authored-by: Omer Lachish <[email protected]>
rauchy added a commit that referenced this pull request Oct 17, 2024
@rauchy
[Release] Release v0.35.0 (#793)
79be9dc 
* Open AI Client Mixin
([#779](#779)).

* Update Serving Endpoint mixing template and docs generation logic
([#792](#792)).

 * Added `databricks.sdk.service.pipelines.ReportSpec` dataclass.
* Added `unity_catalog_provisioning_state` field for
`databricks.sdk.service.catalog.OnlineTable`.
* Added `is_truncated` field for
`databricks.sdk.service.dashboards.Result`.
* Added `effective_budget_policy_id` field for
`databricks.sdk.service.jobs.BaseJob`.
* Added `budget_policy_id` field for
`databricks.sdk.service.jobs.CreateJob`.
* Added `effective_budget_policy_id` field for
`databricks.sdk.service.jobs.Job`.
* Added `budget_policy_id` field for
`databricks.sdk.service.jobs.JobSettings`.
* Added `budget_policy_id` field for
`databricks.sdk.service.jobs.SubmitRun`.
* Added `report` field for
`databricks.sdk.service.pipelines.IngestionConfig`.
* Added `sequence_by` field for
`databricks.sdk.service.pipelines.TableSpecificConfig`.
 * Added `notify_on_ok` field for `databricks.sdk.service.sql.Alert`.
* Added `notify_on_ok` field for
`databricks.sdk.service.sql.CreateAlertRequestAlert`.
* Added `notify_on_ok` field for
`databricks.sdk.service.sql.ListAlertsResponseAlert`.
* Added `notify_on_ok` field for
`databricks.sdk.service.sql.UpdateAlertRequestAlert`.

OpenAPI SHA: cf9c61453990df0f9453670f2fe68e1b128647a2, Date: 2024-10-14

Co-authored-by: Omer Lachish <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunishsheth2009 sunishsheth2009 sunishsheth2009 left review comments

@mgyucht mgyucht mgyucht approved these changes

@smurching smurching Awaiting requested review from smurching

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aravind-segu @mgyucht @sunishsheth2009