[Fix] Fix DatabricksConfig.copy when authenticated with OAuth
#723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR breaks backwards compatibility for databrickslabs/ucx downstream. See build logs for more details. Running from downstreams #374 |
parthban-db
changed the title
DatabricksCliTokenSource().token()DatabricksCliTokenSource().token()
mgyucht
changed the title
DatabricksCliTokenSource().token()DatabricksConfig.copy when authenticated with OAuth
mgyucht
approved these changes
Aug 27, 2024
mgyucht
added a commit
that referenced
this pull request
Aug 28, 2024
### Bug Fixes * Fix `DatabricksConfig.copy` when authenticated with OAuth ([#723](#723)). ### Internal Changes * Fix get_workspace_client test to match Go SDK behavior ([#738](#738)). * Verify that `WorkspaceClient` created from `AccountClient` does actually work through integration tests ([#736](#736)).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
### Bug Fixes * Fix `DatabricksConfig.copy` when authenticated with OAuth ([#723](#723)). ### Internal Changes * Fix get_workspace_client test to match Go SDK behavior ([#738](#738)). * Verify that `WorkspaceClient` created from `AccountClient` does actually work through integration tests ([#736](#736)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
DatabricksCliTokenSource().token()itself can't be copied. So, Deep Copy can't be performed for Config.Added the wrapper function which can be copied. So, Deep copy can be performed.
Tests
make testrun locallymake fmtapplied