Prompts per iteration #94
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcui-db
requested review from
dakinggg,
gupta-abhay,
abaheti95 and
jdchang1
as code owners
dakinggg
approved these changes
Jun 23, 2025
| @@ -959,19 +975,13 @@ def _resolve_outputs( | |||
|
|
|||
| iter_batch.update(env_outs) | |||
|
|
|||
| bs = iter_batch['prompt_id'].shape[0] | |||
There was a problem hiding this comment.
is this bs different from the bs above on line 807?
There was a problem hiding this comment.
It should be the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the notion of
iter_batch_size.This also enables users to specifynum_unique_prompts_per_iterso we are able directly specify this value now. We also enforcenum_unique_prompts_per_iter * generations_per_prompt == global_train_batch_size * num_batches_per_updatedefault-gtbs-64-gen8-lM2EWs- this run runs without specifying thenum_unique_prompts_per_iternppi128-gtbs-64-gen8-mtZcim- this specifies the parameter explicitly