Add Dockerfile #32
Open
Add Dockerfile #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicklan
reviewed
Mar 29, 2018
README.md
Outdated
| @@ -21,6 +21,10 @@ Click is on crates.io, so you can just run `cargo install` to install it. | |||
|
|
|||
| Alternately, to build it yourself, clone the click repository and run `cargo build`. | |||
|
|
|||
| ## Docker build | |||
|
|
|||
| `docker run --rm -it -v $HOME/.kube/:/root/.kube/ click` | |||
There was a problem hiding this comment.
This isn't right is it? It should be something like docker build -t click . in the click directory?
| @@ -34,6 +38,10 @@ can change this with the --config option. | |||
|
|
|||
| Once you're in the REPL, try typing `help` to see what you can do. | |||
|
|
|||
| ## Docker | |||
|
|
|||
| `docker run --rm -it -v $HOME/.kube/:/root/.kube/ click` | |||
There was a problem hiding this comment.
Could you add a note that if any of your certificates are stored outside the .kube dir you'll need to bind that in as well?
There was a problem hiding this comment.
There's also the issue of kubectl configurations that use other commands to gather auth info (e.g. gcloud for GKE clusters).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.