Extract functionality to detect if the CLI is running on DBR #1889
+345
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
Test Details: go/deco-tests/11731384827 |
shreyas-goenka
approved these changes
Nov 8, 2024
|
|
||
| import "context" | ||
|
|
||
| // key is a private type to prevent collisions with other packages. |
There was a problem hiding this comment.
nit: I don't understand this comment. Wouldn't the type still be namespaced within the DB package?
|
|
||
| // RunsOnRuntime returns the cached detection result from the context. | ||
| // It expects a context returned by [DetectRuntime] or [MockRuntime]. | ||
| func RunsOnRuntime(ctx context.Context) bool { |
There was a problem hiding this comment.
Can you add a one line note regarding why we cache the result? I presume it's because the stat("/databricks") call can be expensive on DBR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Whether or not the CLI is running on DBR can be detected once and stored in the command's context.
By storing it in the context, it can easily be mocked for testing.
This builds on the simpler approach and conversation in #1744. It unblocks testing of the DBR-specific paths while not compromising on the checks we can perform to test if the CLI is running on DBR.
Tests
dbrpackageConfigureWSFSmutator