Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(query): add sort plan before window plan #15616

Merged
merged 6 commits into from
May 23, 2024
Merged

chore(query): add sort plan before window plan #15616

merged 6 commits into from
May 23, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented May 22, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

add sort plan before window plan, so we can eliminated the order by in multi-window clauses.

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@sundy-li sundy-li requested a review from xudong963 May 22, 2024 15:13
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label May 22, 2024
@sundy-li sundy-li marked this pull request as draft May 22, 2024 15:15
@sundy-li sundy-li marked this pull request as ready for review May 23, 2024 00:12
@BohuTANG BohuTANG added the ci-cloud Build docker image for cloud test label May 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-15616-4c9b5ae

note: this image tag is only available for internal use,
please check the internal doc for more details.

@BohuTANG BohuTANG merged commit e64e102 into databendlabs:main May 23, 2024
79 checks passed
yufan022 pushed a commit to yufan022/databend that referenced this pull request Jun 5, 2024
@sundy-li @yufan022
chore(query): add sort plan before window plan (databendlabs#15616)
f8b4a7f 
* chore(query): add sort plan before window plan

* chore(query): add sort plan before window plan

* chore(query): add sort plan before window plan

* chore(query): add sort plan before window plan

* chore(query): add sort plan before window plan
yufan022 pushed a commit to yufan022/databend that referenced this pull request Jun 14, 2024
@sundy-li @yufan022
chore(query): add sort plan before window plan (databendlabs#15616)
c1ac176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xudong963 xudong963 xudong963 approved these changes

Assignees
No one assigned
Labels
ci-cloud Build docker image for cloud test pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sundy-li @xudong963 @BohuTANG