Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): fix filter reorder check #15613

Merged
merged 6 commits into from
May 23, 2024

Conversation

Dousir9
Copy link
Member

@Dousir9 Dousir9 commented May 22, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Use Expr instead of function name to check if filter reorder is allowed.

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label May 22, 2024
@Dousir9 Dousir9 requested a review from sundy-li May 22, 2024 15:48
@Dousir9 Dousir9 changed the title chore(query): support filter execution short circuit chore(query): fix filter reorder check May 22, 2024
@Dousir9 Dousir9 marked this pull request as ready for review May 22, 2024 15:49
@Dousir9 Dousir9 requested a review from xudong963 May 22, 2024 15:49
@xudong963 xudong963 added this pull request to the merge queue May 23, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request May 23, 2024
@BohuTANG BohuTANG merged commit b80bb5d into databendlabs:main May 23, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants