Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TxnManager with state AutoCommit should not be saved in http manager. #15602

Merged
merged 3 commits into from
May 22, 2024

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented May 22, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

which leads to unexpected log like transaction timeout after 14400 timeout

  • let me test it against our clients.
    • go
    • jdbc

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label May 22, 2024
@SkyFan2002
Copy link
Member

LGTM. But it I'm worried that if the timeout statement is executed in a multi statement transaction, It will still time out. I'm not sure if it's enough for the transaction status to be retained for four hours. @youngsofun @dantengsky

@youngsofun
Copy link
Member Author

@SkyFan2002
the older timer is canceled on next statement, a new timer is start when it finish

@BohuTANG BohuTANG merged commit b23080d into databendlabs:main May 22, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants