Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor session. #101

Merged
merged 1 commit into from
Feb 29, 2024
Merged

refactor session. #101

merged 1 commit into from
Feb 29, 2024

Conversation

youngsofun
Copy link
Member

  1. group the session infos together, update as a whole. make it easier when add more field to SessionState.
  2. update SessionState on each resp.

@youngsofun
Copy link
Member Author

cc @hantmac

@youngsofun youngsofun mentioned this pull request Feb 29, 2024
Open
13 tasks
hantmac
hantmac approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@hantmac hantmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hantmac hantmac merged commit 94a6f5e into databendlabs:main Feb 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hantmac hantmac hantmac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youngsofun @hantmac