Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup from MySQL Community Edition #119

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

karthikeayan
Copy link

Fix for #105

@deitch
Copy link
Collaborator

deitch commented Sep 11, 2019

Hi @karthikeayan ; thanks for offering this up.

There are two different changes rolled up here together. I like them both, but we need to separate them out into separate PRs for management. What I see here is:

  • support for an image based on debian-stretch-slim, that installs an actual mysql (not mariadb) client, to avoid current (and potential future) compatibility issues.
  • Description and sample files for deploying into kubernetes

Let's do the following:

  1. Create one PR just for the Kubernetes work. Roll that documentation into the main README.md, or at least have it as a separate file with a link to it. Those don't go under debian-mysql-core/ but in the main dir
  2. Reuse this PR (or create a clean new one) that just builds the image as an option based on debian so the installed client is true mysql.

For the latter, I am going to consider creating a separate mariadb-backup for the current implementation, and have this be mysql-backup for true mysql. I need to think through how to avoid duplicate work, but it should be doable. Let's get the PR in first.

@deitch
Copy link
Collaborator

deitch commented Jan 19, 2020

Hi @karthikeayan . I changed CI to run on GitHub actions. Do you mind rebasing it?

@karthikeayan
Copy link
Author

@deitch did rebase

@deitch
Copy link
Collaborator

deitch commented Jan 31, 2022

I am not quite sure what to make of this. It looks like a whole separate dir named debian-mysql-core/, but what is in it and how is it used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants