Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where $AWS_ENDPOINT_OPT is ignored #113

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sadortun
Copy link

@sadortun sadortun commented Jul 5, 2019

when $AWS_ENDPOINT_URL present

 when $AWS_ENDPOINT_URL present
 when $AWS_ENDPOINT_URL present
@deitch
Copy link
Collaborator

deitch commented Jul 7, 2019

This isn't 100% correct. As of now, AWS_ENDPOINT_OPT is not a published variable you can use. It is an internal var to functions.sh and entrypoint. That having been said, it does read it using file_env, so it implies it would be recognized. It sort of is between the fences.

This would make it into a recognized first-class var that can be set, which is a "good thing".

Let's add this to the README as documentation, and then it officially will become one, and we can merge it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants