Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back to results feature #376

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Back to results feature #376

merged 3 commits into from
Feb 14, 2023

Conversation

YolineB
Copy link
Contributor

@YolineB YolineB commented Feb 14, 2023

PR Overview

When user applies a search in the search filter box, user should return to same filtered page when navigating between searches and specific event.

Type of contribution

  • Code
  • Documentation

Reference: Issue or Pull Request (PR)

Description of Changes

HomePage searchForm params, SearchForm props, useNavigate for ReviewEventMainSection, events.js consts

Before and After for UI Updates

Before:

SearchBoxBefore.mov

After:

SearchBoxAfter.mov

For PR Reviewer

  • Does this file change the yarn.lock, package.json or package-lock.json file? If so, why?
  • If this pr contains mobile and desktop changes, did you test on IphoneXr and desktop views?
  • Does this file match the related tickets linked figma file, or does it pass the visual smell test?
  • If this file contains javascript, does the javascript pass the smell test?
  • If you don't feel super confident in your review, did you assign someone more senior to double check?

@YolineB YolineB self-assigned this Feb 14, 2023
Copy link
Contributor

@dashcraft dashcraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good at first glance, lower surface area

@YolineB YolineB merged commit e435c93 into main Feb 14, 2023
@YolineB YolineB deleted the 116/back-to-results-feature branch February 14, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants