Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Form Validations #370

Merged
merged 7 commits into from
Feb 10, 2023
Merged

Event Form Validations #370

merged 7 commits into from
Feb 10, 2023

Conversation

YolineB
Copy link
Contributor

@YolineB YolineB commented Feb 8, 2023

PR Overview

Add validation for following fields in Event Form

  • Event Name
  • Event Start Date
  • Event Registration URL (update this to "Event URL")

Type of contribution

  • Code
  • Documentation

Reference: Issue or Pull Request (PR)

Description of Changes

Update validation schema in EventForm.jsx, and update test for page accordingly

Before and After for UI Updates

Before:
image
image

After:
Desktop
image
image
image

For PR Reviewer

  • Does this file change the yarn.lock, package.json or package-lock.json file? If so, why?
  • If this pr contains mobile and desktop changes, did you test on IphoneXr and desktop views?
  • Does this file match the related tickets linked figma file, or does it pass the visual smell test?
  • If this file contains javascript, does the javascript pass the smell test?
  • If you don't feel super confident in your review, did you assign someone more senior to double check?

@YolineB YolineB self-assigned this Feb 10, 2023
Copy link
Contributor

@dashcraft dashcraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@YolineB YolineB merged commit 8fdc2d5 into main Feb 10, 2023
@YolineB YolineB deleted the 284/event-form-submission branch February 10, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants