about-us-logo-fix #237
Open
about-us-logo-fix #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return ( | ||
| <div key="aboutUsgrid" className={aboutStyleClasses.aboutUsCards}> | ||
| <div className="grid grid-rows-1 md:m-0 p-2 m-6 border-2 border-black dark:border-du-lightAqua dark:text-white dark:bg-slate-700 rounded bg-white"> | ||
| <div className="py-4"> | ||
| <img src={DULogo} alt="logo" className={`mx-auto`}/> | ||
| <img src={colorTheme ==='light'?DULogo:DULogoWhiteBg} alt="logo" className={`mx-auto h-32`}/> |
There was a problem hiding this comment.
Put this conditional logic into a variable above the return.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Description
Fixes #212
Description of Changes
Added White background Data Umbrella Logo.
I've fixed the issue for now but it would be nice if we have a dark mode version of the transparent logo currently in use.
Before and After for UI Updates
Before (PC)
After (PC)
Before (Iphone 12)
After (Iphone 12)
For PR Reviewer