Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update contributing guide #82

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Conversation

reshamas
Copy link
Contributor

Description: What does this implement/fix? Explain your changes.

  • add guide
  • add skills

Reference: Issue or Pull Request (PR)

Towards #35

Reminders

  • Did you review the CONTRIBUTING GUIDE?
  • Did you reference an issue or another pull request?

Any other comments?

@netlify
Copy link

netlify bot commented Feb 20, 2023

Deploy Preview for majestic-souffle-d006f2 canceled.

Name Link
🔨 Latest commit 805a620
🔍 Latest deploy log https://app.netlify.com/sites/majestic-souffle-d006f2/deploys/63f4bcd52ce47e00081cc0c3

@SangamSwadiK SangamSwadiK added the documentation Improvements or additions to documentation label Feb 21, 2023
Copy link
Contributor

@SangamSwadiK SangamSwadiK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !
Do you think we should add a sentence on asking permission to start a PR? something like ?

You can work on any existing issues unless someone there is already a PR raised. In case if you find a PR stale, please tag and ask the person if they wish to continue their PR and wait for a day before starting to work on it...

@reshamas
Copy link
Contributor Author

@SangamSwadiK

You can work on any existing issues unless someone there is already a PR raised. In case if you find a PR stale, please tag and ask the person if they wish to continue their PR and wait for a day before starting to work on it...

I added a section on issues. I generally don't like following up on stale PRs like this because most contributors who abandon issues don't really respond to questions related to them.

@reshamas reshamas merged commit 8aa3bef into data-umbrella:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

2 participants