Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrangler UI features #720

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Wrangler UI features #720

merged 1 commit into from
Nov 20, 2024

Conversation

AnkitCLI
Copy link
Contributor

@AnkitCLI AnkitCLI commented Nov 7, 2024 •
edited
Loading

This PR contains feature files for runtime scenarios of wrangler

@AnkitCLI AnkitCLI changed the title This PR contains feature files for runtime scenarios of wrangler Wrangler UI features Nov 7, 2024
@bharatgulati bharatgulati added the build Triggers unit test build label Nov 7, 2024
@AnkitCLI AnkitCLI force-pushed the Wrangler-UI-e2e branch 4 times, most recently from ef13733 to 0be9e5c Compare November 15, 2024 15:05
@AnkitCLI AnkitCLI marked this pull request as ready for review November 15, 2024 17:15
@GnsP
Copy link

GnsP commented Nov 18, 2024

@AnkitCLI Could you please link the PRs with the stepdefinitions as well ?
The features look good to me, though I would prefer to cross reference with the step defs.

@AnkitCLI
Copy link
Contributor Author

AnkitCLI commented Nov 18, 2024 •
edited
Loading

@AnkitCLI Could you please link the PRs with the stepdefinitions as well ? The features look good to me, though I would prefer to cross reference with the step defs.

@GnsP This is the framework repo PR which is already merged contains all the locators,stepdefs and action classes for wrangler u can refer this: cdapio/cdap-e2e-tests#251

GnsP
GnsP requested changes Nov 19, 2024
View reviewed changes
wrangler-transform/src/e2e-test/features/WranglerUI/ParseAsExcel.feature Outdated
@Wrangler
Feature: Parse as excel

@BQ_SINK_TEST
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the indentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

wrangler-transform/src/e2e-test/java/io/cdap/plugin/wrangler/runners/TestRunner.java
@@ -26,7 +26,7 @@
@CucumberOptions(
features = {"src/e2e-test/features"},
glue = {"stepsdesign", "io.cdap.plugin.common.stepsdesign", "io.cdap.plugin.wrangler.stepsdesign",
"io.cdap.plugin.wrangler.locators"},
"io.cdap.plugin.wrangler.actions"},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to add both "io.cdap.plugin.wrangler.stepsdesign" and "io.cdap.plugin.wrangler.actions" packages in the glue ? Shouldn't the step definitions for wrangler reside in one package ?

Copy link
Contributor Author

@AnkitCLI AnkitCLI Nov 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

io.cdap.plugin.wrangler.stepsdesign is for wrangler class to validate the data and io.cdap.plugin.wrangler.actions it contains wrangler actions so that's why we put them in different folders but same package we have a common directory named wrangler in which these two folders exists.

@psainics psainics merged commit 459c18e into data-integrations:develop Nov 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GnsP GnsP GnsP approved these changes

Assignees
No one assigned
Labels
build Triggers unit test build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnkitCLI @GnsP @bharatgulati @psainics