Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection manager E2E - SFMC #44

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

satyamsufi
Copy link

E2E test cases for Salesforce marketing cloud with connection manager.

@@ -69,3 +69,20 @@ Feature: Salesforce Marketing Cloud Sink - Design time validation scenarios
And Click on the Validate button
Then Verify mandatory property error for below listed properties:
| dataExtension |

@BATCH-TS-SFMC-DSGN-ERROR-04
Scenario: Verify user should be able to get invalid credentials validation message when using invalid credentials in the connection manager functionality

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Scenario: Verify user should be able to get invalid credentials validation message when using invalid credentials in the connection manager functionality
Scenario: Verify user should get invalid credentials error message for TestConnection when using invalid credentials in the connection manager functionality

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chnages done

@@ -78,3 +78,20 @@ Feature: Salesforce Marketing Cloud Source - Design time Validation scenarios
| DATA_EXTENSION | BOUNCE_EVENT |
And Click on the Validate button
Then Verify that the Plugin Property: "dataExtensionKeyList" is displaying an in-line error message: "required.property.dataextensionkeymultiobject"

@BATCH-TS-SFMC-DSGN-ERROR-05
Scenario: Verify user should be able to get invalid credentials validation message when using invalid credentials in the connection manager functionality

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Scenario: Verify user should be able to get invalid credentials validation message when using invalid credentials in the connection manager functionality
Scenario: Verify user should get invalid credentials error message when using invalid credentials in the connection manager functionality

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

Copy link

@Aryan-Verma Aryan-Verma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please look into the failing github actions tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants