[Plugin-1730] Adding XLS UI elements for ftp source #48
Conversation
There was a problem hiding this comment.
Most comments from data-integrations/google-cloud#1368 are also applicable here. Looks good apart from those.
psainics
force-pushed
the
patch-ftp-xls-ui
branch
from
e4ea508 to
742584a
Compare
psainics
force-pushed
the
patch-ftp-xls-ui
branch
2 times, most recently
from
feaa2f3 to
cae123d
Compare
Changes done as per comments |
widgets/FTPSource-batchsource.json
Outdated
| }, | ||
| { | ||
| "widget-type": "toggle", | ||
| "label": "Terminate If Empty Row", |
There was a problem hiding this comment.
this sounds a bit unclear and technical for a toggle label:
some suggestions:
Stop Reading at First Empty RowStop on First Empty RowTerminate Reading After Empty Row
There was a problem hiding this comment.
Took reference from this: https://github.com/cdapio/hydrator-plugins/blob/f6363b0d4bf7e753c11f946c3594549f0acc4104/core-plugins/widgets/Excel-batchsource.json#L100
This is how it is there in Excel plugin.
There was a problem hiding this comment.
I think we should change at both places then to make it consistent and human readable everywhere.
|
Adding XLS UI elements for ftp source
Jira : Plugin-1730
Description
This PR adds UI element required for XLS Support in
FTP Source.Ref : XLS Support PR cdapio/hydrator-plugins#1835
Added Fields
A filter is used to show XLS specific values
Terminate If Empty Row,Select Sheet Using,Sheet Valueonly when formatXLSis selected.Preview