Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2778 fix #2779

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

2778 fix #2779

wants to merge 2 commits into from

Conversation

ziv17
Copy link
Collaborator

@ziv17 ziv17 commented Feb 26, 2025

Closes #2778

Fix road segment
Support pagination in a similar manner as done in news flash API.

Add two non-mandatory parameters:
page_number, default: 0.
page_size, default: 8192
Change the structure of the result:

{
"data": [ {...}, {...}, ...],
"pagination": {
"page_number": ,
"page_size":
}
}

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 10.34483% with 26 lines in your changes missing coverage. Please review.

Project coverage is 54.22%. Comparing base (07a333b) to head (235f093).
Report is 26 commits behind head on dev.

Files with missing lines Patch % Lines
anyway/views/safety_data/involved_query.py 7.14% 26 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2779      +/-   ##
==========================================
+ Coverage   52.57%   54.22%   +1.65%     
==========================================
  Files         122      126       +4     
  Lines       10232    10677     +445     
==========================================
+ Hits         5379     5790     +411     
- Misses       4853     4887      +34     
Flag Coverage Δ
unittests 54.22% <10.34%> (+1.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ziv17 ziv17 marked this pull request as ready for review February 28, 2025 05:37
@ziv17 ziv17 requested review from tkalir and atalyaalon February 28, 2025 05:37
Copy link
Collaborator

@tkalir tkalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know this part of the code base much, but looks good. Tell me if you want a review for something specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Safety Data involved/ API returns duplicated entries with wrong road segments
3 participants