Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring extract_geo_features #2704

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

tkalir
Copy link
Collaborator

@tkalir tkalir commented Sep 15, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 15.38462% with 22 lines in your changes missing coverage. Please review.

Project coverage is 52.77%. Comparing base (400af13) to head (46b0b81).
Report is 100 commits behind head on dev.

Files with missing lines Patch % Lines
anyway/parsers/location_extraction.py 16.66% 20 Missing ⚠️
anyway/parsers/news_flash.py 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2704      +/-   ##
==========================================
- Coverage   53.22%   52.77%   -0.46%     
==========================================
  Files         119      122       +3     
  Lines        9924    10108     +184     
==========================================
+ Hits         5282     5334      +52     
- Misses       4642     4774     +132     
Flag Coverage Δ
unittests 52.77% <15.38%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


if newsflash.resolution in [
BE_CONST.ResolutionCategories.STREET,
BE_CONST.ResolutionCategories.SUBURBAN_ROAD,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest using SUPPORTED_RESOLUTIONS
It consists of ResolutionCategories.SUBURBAN_JUNCTION, but that's ok since it will be a supported soon)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, done

@tkalir tkalir merged commit 0e9a621 into data-for-change:dev Sep 17, 2024
3 checks passed
@atalyaalon atalyaalon linked an issue Sep 18, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor extract_geo_features
3 participants