Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix multiple choices checkbox component #1494

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

fhlavac
Copy link
Contributor

@fhlavac fhlavac commented Nov 25, 2024

Fixes #1493

Description

Changed order of the onChange params to fix checkbox filters toggle

Schema (if applicable)

export default {
  "fields": [
    {
      "component": "checkbox",
      "label": "Checkbox",
      "name": "checkbox",
      "options": [
        {
          "label": "Dog",
          "value": "1"
        },
        {
          "label": "Cats",
          "value": "2"
        },
        {
          "label": "Hamsters",
          "value": "3"
        }
      ]
    }
  ]
};

Checklist: (please see documentation page for more information)

  • Yarn build passes
  • Yarn lint passes
  • Yarn test passes
  • [-] Test coverage for new code (if applicable)
  • [-] Documentation update (if applicable)
  • Correct commit message
    • format fix|feat({scope}): {description}
    • i.e. fix(pf3): wizard correctly handles next button
    • fix will release a new _._.X version
    • feat will release a new _.X._ version (use when you introduce new features)
      • we want to avoid any breaking changes, please contact us, if there is no way how to avoid them
    • scope: package
    • if you update the documentation or tests, do not use this format
      • i.e. Fix button on documenation example page

cc @Hyperkid123

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-forms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 0:58am

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.50%. Comparing base (26119e0) to head (733f960).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1494   +/-   ##
=======================================
  Coverage   94.50%   94.50%           
=======================================
  Files         210      210           
  Lines        3984     3984           
  Branches     1633     1633           
=======================================
  Hits         3765     3765           
  Misses        219      219           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@rvsia rvsia merged commit 63f19dc into data-driven-forms:master Nov 25, 2024
6 checks passed
@rvsia rvsia added the released label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple checkbox PF4 input does not work
2 participants