Clean up S3 Buckets in integration test #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrkalos
reviewed
Oct 2, 2024
| self._resource = session.resource('s3', region_name=region) | ||
| self._region = region | ||
|
|
||
| def delete_bucket(self, bucket_name): |
There was a problem hiding this comment.
you need to account for access points as well (if bucket have them it will fail)
There was a problem hiding this comment.
In a happy path world, we should not run into that situation because a dataset can only be deleted if all shares are revoked and if shares are revoked the access points are deleted. However, if the tests for revoking access points fail, then we would face this situation when tearing down resources. It is easy enough to implement, so I am adding it to the PR
There was a problem hiding this comment.
Tested! Now it is ready to be merged. Do you want to have a final look @petrkalos ?
…n-up-buckets-integration-test # Conflicts: # tests_new/integration_tests/core/environment/global_conftest.py
petrkalos
reviewed
Oct 7, 2024
petrkalos
approved these changes
Oct 7, 2024
|
Not merging yet because while testing the code for access points a small error appeared. Wait for updates on this PR |
dlpzx
force-pushed
the
fix/clean-up-buckets-integration-test
branch
from
5421146
to
e014991
Compare
dlpzx
added a commit
that referenced
this pull request
Oct 9, 2024
### Feature or Bugfix - Bugfix ### Detail This PR fixes a mismatch between the #1607 and #1603 where get_environment_aws_session is no longer used. In this PR we obtain the session from the new STSClient refreshable token functions introduced in #1607 ### Relates - #1603 - #1607 ### Security Please answer the questions below briefly where applicable, or write `N/A`. Based on [OWASP 10](https://owasp.org/Top10/en/). - Does this PR introduce or modify any input fields or queries - this includes fetching data from storage outside the application (e.g. a database, an S3 bucket)? - Is the input sanitized? - What precautions are you taking before deserializing the data you consume? - Is injection prevented by parametrizing queries? - Have you ensured no `eval` or similar functions are used? - Does this PR introduce any functionality or component that requires authorization? - How have you ensured it respects the existing AuthN/AuthZ mechanisms? - Are you logging failed auth attempts? - Are you using or adding any cryptographic features? - Do you use a standard proven implementations? - Are the used keys controlled by the customer? Where are they stored? - Are you introducing any new policies/roles/users? - Have you used the least-privilege principle? How? By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
Environment and Dataset stacks leave S3 Buckets to be deleted even when the CloudFormation stack is deleted.
This PR deletes the S3 Buckets when the session and temp fixtures for datasets and environments are deleted.
Testing
Tested that environment and dataset buckets are all deleted - in real AWS CICD pipeline with NOT-empty buckets.
Tested that dataset buckets with some manually created access points succeed.
Relates
Security
Please answer the questions below briefly where applicable, or write
N/A. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
evalor similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.