Skip to content

update docs on how to opt-in #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2023
Merged

update docs on how to opt-in #172

merged 2 commits into from
Jun 21, 2023

Conversation

MarcoGorelli
Copy link
Contributor

closes #169

rgommers
rgommers reviewed May 19, 2023
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Marco. A few questions.

@MarcoGorelli MarcoGorelli requested a review from rgommers May 22, 2023 17:26
@MarcoGorelli
Copy link
Contributor Author

any further action needed here?

@rgommers rgommers added the documentation Improvements or additions to documentation label Jun 21, 2023
rgommers
rgommers approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM now, thanks @MarcoGorelli

@rgommers rgommers merged commit 04650ba into data-apis:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

address issue with __dataframe_namespace__ and non-compliant dataframes
2 participants
@MarcoGorelli @rgommers